You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Jackson you need a couple extra modules for in order to use any features like java.time.LocalDateTime. When I add those module dependencies to my project, JacksonMapper does not find them/use them. I can override JacksonMapper and create my own mapping class, that can include those modules, that works just fine. However, it would be nice to include them automatically.
The object mapper for Jackson appears to have a method titled, "findAndRegisterModules" which in my testing, finds all Jackson modules and includes them. Could this be the default for JacksonMapper? That way when wanting to use Java 8 time functions, all a user has to do is include the extra modules with dependency management of their choice and not extend JacksonMapper, which is more complex and has more potential for them to make mistakes(?).
I saw similar issues (#51 and #59 ) however those are dealing with Kotlin and did not appear to carry over to Java.
I would open a pull request, but I am still learning how to contribute on GitHub and wouldn't want to mess anything up. Many thanks!
The text was updated successfully, but these errors were encountered:
No worries. Please go ahead and create a pull request if you are willing, I'll be more than glad for your contribution. Please don't forget to add sufficient test cases also.
Before merging all pull requests in github go through a manual review, so no chance of messing things up 😄.
Oops, though I replied but apparently not. At this point, even though it is going to only be one line of code and then a few tests (although I can't think of any), I don't think it makes sense for me to make the changes (it is slightly out of my comfort zone). If you really feel like it would be too much work the I can but this is really more of a want then a need. Thank you for this awesome project, I really see how useful it can be!
When using Jackson you need a couple extra modules for in order to use any features like
java.time.LocalDateTime
. When I add those module dependencies to my project,JacksonMapper
does not find them/use them. I can overrideJacksonMapper
and create my own mapping class, that can include those modules, that works just fine. However, it would be nice to include them automatically.The object mapper for Jackson appears to have a method titled, "findAndRegisterModules" which in my testing, finds all Jackson modules and includes them. Could this be the default for
JacksonMapper
? That way when wanting to use Java 8 time functions, all a user has to do is include the extra modules with dependency management of their choice and not extendJacksonMapper
, which is more complex and has more potential for them to make mistakes(?).I saw similar issues (#51 and #59 ) however those are dealing with Kotlin and did not appear to carry over to Java.
I would open a pull request, but I am still learning how to contribute on GitHub and wouldn't want to mess anything up. Many thanks!
The text was updated successfully, but these errors were encountered: