Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form input tag's name attribute should handle all of CDATA #13

Open
jbothma opened this issue Aug 21, 2012 · 2 comments
Open

form input tag's name attribute should handle all of CDATA #13

jbothma opened this issue Aug 21, 2012 · 2 comments

Comments

@jbothma
Copy link

jbothma commented Aug 21, 2012

A form input tag's name attribute should be able to contain any CDATA characters. At least according to http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd

Currently quite a limited (albeit the vastly most common) set of characters are supported by https://github.com/nitrogen/simple_bridge/blob/master/src/simple_bridge_request_wrapper.erl#L97 but it breaks when you want to parse an array of things like Chicago Boss model IDs like the following because of the hyphen

<input type... name="items[word-3]" />
<input type... name="items[word-5]" />

Of course there are many workarounds and I'm not even providing a patch, but I thought I'd log the issue until I can provide a patch ans see if there's any interest in such a fix anyway.

@choptastic
Copy link
Member

A solid recommendation. If it's breaking the standard, it should definitely be fixed.

This should be an easy fix of the regex, and if you want to do it so that you're included in the repo history, go right ahead and submit a pull request.

@jbothma
Copy link
Author

jbothma commented Aug 26, 2012

Cool. I won't get to it for a few weeks (that project's on the backburner) so go ahead if you have time, otherwise I'll be back when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants