Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding custom vary header for static assets #2834

Closed
1 task done
daniluk4000 opened this issue Nov 2, 2024 · 0 comments · Fixed by #2835
Closed
1 task done

Allow adding custom vary header for static assets #2834

daniluk4000 opened this issue Nov 2, 2024 · 0 comments · Fixed by #2835
Labels
enhancement New feature or request static

Comments

@daniluk4000
Copy link
Contributor

Describe the feature

Due to

nitro/src/runtime/internal/static.ts

Line 51 in 4081e63

if (encodings.length > 1) {
it is sometimes impossible to set custom Vary header. We are currently experiencing CORS errors because of that.

Additional information

  • Would you be willing to help implement this feature?
@daniluk4000 daniluk4000 mentioned this issue Nov 2, 2024
Merged
8 tasks
@pi0 pi0 added enhancement New feature or request static and removed pending triage labels Nov 2, 2024
@pi0 pi0 changed the title Custom Vary header Allow adding custom vary header for static assets Nov 2, 2024
@pi0 pi0 closed this as completed in #2835 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request static
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow adding custom Vary to static assets handler daniluk4000/nitro
2 participants
@pi0 @daniluk4000