Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): enable dotenv in development #347

Merged
merged 1 commit into from
Jul 15, 2022
Merged

fix(config): enable dotenv in development #347

merged 1 commit into from
Jul 15, 2022

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented Jul 14, 2022 •
edited
Loading

🔗 Linked issue

Fixes #246

🔗 Linked discussion

Closes #238

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This enables dotenv setup feature from c12 in development (nitro dev only), making .env files working out of the box.

@kevinmarrec kevinmarrec requested a review from pi0 July 14, 2022 19:51
pi0
pi0 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Thanks!

@pi0 pi0 merged commit ec086c6 into nitrojs:main Jul 15, 2022
@kevinmarrec kevinmarrec deleted the fix-dotenv branch July 15, 2022 10:10
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
@kevinmarrec @WinterYukky
fix(config): enable dotenv in development (nitrojs#347)
2d83581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.env file don't load in config
2 participants
@kevinmarrec @pi0