Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only log unhandled/fatal errors #407

Merged
merged 3 commits into from
Aug 10, 2022
Merged

fix: only log unhandled/fatal errors #407

merged 3 commits into from
Aug 10, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

unjs/h3#162

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We can use the h3-sourced fatal/unhandled flags to tell us when to log errors.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 10, 2022
@danielroe danielroe requested a review from pi0 August 10, 2022 14:55
@danielroe danielroe self-assigned this Aug 10, 2022
src/runtime/error.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #407 (a71c7d0) into main (e10f130) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   56.21%   56.21%           
=======================================
  Files          54       54           
  Lines        3467     3467           
  Branches      367      367           
=======================================
  Hits         1949     1949           
  Misses       1165     1165           
  Partials      353      353           
Impacted Files Coverage Ξ”
src/dev/server.ts 15.13% <50.00%> (ΓΈ)
src/types/handler.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 2d5b039 into main Aug 10, 2022
@pi0 pi0 deleted the fix/unhandled-errors branch August 10, 2022 15:11
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants