-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sanitizeDerivationName seems unnecessary #260
Comments
I think this makes sense. Could this change break anything though? |
No breaking change, it only means rebuilding packages |
I'm not opposed to removing the custom sanitizing. I just thought, that with |
In any case, RFC #17 proposes doing away with names in store paths, and the actual name of the package is evident in the lib/node_modules directory. So I don't think there's much opportunity for confusion. |
OK, I'm fine with removing the use of sanitizDerivationName. |
Resolved in #315 |
there's
which results in long and unreadable names for modules like
__at__babel__slash__runtime
, and there's no technical need for it, since Nix will sanitize names like@babel/runtime
to-babel-runtime
.How about not sanitizing derivation names?
The text was updated successfully, but these errors were encountered: