Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Lighthouse #227

Open
selfuryon opened this issue Apr 21, 2023 · 2 comments
Open

Fix tests for Lighthouse #227

selfuryon opened this issue Apr 21, 2023 · 2 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@selfuryon
Copy link
Collaborator

Hi!
I disabled web3signer downloads in lighthouse and remove current patch (#224) because:

  • we disabled tests anyway
  • in last release lighthouse merged PR #4163 in which they started to use dynamic temp dirs, so they reworked how it works now.

I think we need to make PR to them with capability to check env var and use that path (if it exists) to web3signer binary without downloading.

@selfuryon selfuryon self-assigned this Apr 21, 2023
@aldoborrero
Copy link
Collaborator

@selfuryon sounds good to me, will you propose such PR? Let me know

@selfuryon
Copy link
Collaborator Author

@aldoborrero yeah, I will do that in several days, it looks like an easy task for the first view

@aldoborrero aldoborrero changed the title lighthouse: fix tests Fix tests for Lighthouse Jun 7, 2023
@aldoborrero aldoborrero added the Type: Bug Something isn't working label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants