bug: tmux with 'sensibleOnTop' option no longer uses the correct shell

[cixel]

Are you following the right branch?

• My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

• I have searched the existing issues

Issue description

The upstream version of tmux was updated last week to 3.5a (commit). One of the changes in this version (from 3.5) is that /bin/sh is used for run-shell.

With this version of tmux, all panes/windows/etc use sh instead of the configured default shell (in my case, zsh).

My rough guess is that this change in tmux has introduced some ordering issues when sensibleOnTop is set, as run-shell will now use sh regardless of how tmux's default-shell is set.

The problem goes away if I do:

  package = pkgs.tmux.overrideAttrs (old: rec {
    version = "3.5";
    src = pkgs.fetchFromGitHub {
      owner = "tmux";
      repo = "tmux";
      rev = version;
      hash = "sha256-8CRZj7UyBhuB5QO27Y+tHG62S/eGxPOHWrwvh1aBqq0=";
    };
  });

or if I set sensibleOnTop = false;

Maintainer CC

@jorsn @rycee (cc based on a7cdfaa).

System information

- system: `"aarch64-darwin"`
 - host os: `Darwin 23.6.0, macOS 14.7`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.8`
 - channels(ehdens): `"home-manager, nixpkgs"`
 - nixpkgs: `/Users/ehdens/.nix-defexpr/channels/nixpkgs`