Bin builds #11
Bin builds #11
Conversation
handle pre and postConfigure phases.
A small utility to install nodejs headers
Each node package is like a little snowflake. Fetching things left and right. This commit adds some examples for common bin dependencies. It's not the best experience but at least we have an example available.
| writeScript "nodejs-headers-installer" '' | ||
| echo "* Installing nodejs headers in $HOME/.node-gyp/${nodejs.version} ..." | ||
| mkdir -p $HOME/.node-gyp/${nodejs.version} | ||
| echo 9 > $HOME/.node-gyp/${nodejs.version}/installVersion |
There was a problem hiding this comment.
I don't remember. This code has been cargo-culted heavily :)
There was a problem hiding this comment.
| @@ -266,14 +266,25 @@ let | |||
| echo " > repl" | |||
| ''; | |||
| }; | |||
|
|
|||
| nodejs-headers-installer = | |||
There was a problem hiding this comment.
can you add a few lines here about how this is meant to be used? i.e. "make sure your $HOME is set and call this executable".
There was a problem hiding this comment.
👍 I was thinking of adding a $HOME check in the script itself instead.
| @@ -266,14 +266,25 @@ let | |||
| echo " > repl" | |||
| ''; | |||
| }; | |||
|
|
|||
| nodejs-headers-installer = | |||
| with pkgs; | |||
There was a problem hiding this comment.
let's just use pkgs.writeScript, pkgs.nodejs, etc
|
|
||
| nodejs.passthru.python | ||
|
|
||
| # These tend to be needed when |
| ]; | ||
|
|
||
| postConfigure = '' | ||
| ${nodejs-headers-installer} |
There was a problem hiding this comment.
I remember having to do something like this, and I think it worked without having to write anything to HOME. Though maybe it was something different?
''
...
export CPATH="${pkgs.nodejs-10_x}/include/node:$CPATH"
npm install --nodedir=${pkgs.nodejs-10_x}/include/node
...
''
There was a problem hiding this comment.
Thanks. I managed to avoid failing to download the headers with npmCommands = ["npm install --nodedir=${pkgs.nodejs}/include/node --loglevel verbose"];
(Although it eventually failed because there was no /usr/bin/env in a sandboxed build)
|
|
||
| ln -s ${pkgs.pngquant}/bin/pngquant node_modules/pngquant-bin/vendor/pngquant | ||
|
|
||
| runPostinstall() ( |
There was a problem hiding this comment.
shall we just inline this below?
|
thanks for the review, I will make another pass when I have the time/energy |
|
Closing as https://github.com/tweag/npmlock2nix is now serving the same purpose for me. |
Adds a few fixes and an example of bin dependencies.
Fixes #9 -ish