Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what todo with recursion #1477

Open
patryk4815 opened this issue Dec 29, 2023 · 2 comments
Open

what todo with recursion #1477

patryk4815 opened this issue Dec 29, 2023 · 2 comments

Comments

@patryk4815
Copy link
Contributor

patryk4815 commented Dec 29, 2023

poetry packages:

ipalib = "^4.10.2"
ipaclient = "^4.10.2"

Recursion in poetry.lock:

ipaclient -> ipalib -> ipaplatform -> ipapython -> ipaplatform -> ipapython -> ... recursion

What todo in that case? Manually should I modify poetry.lock and remove recursion?

ipaplatform depends on ipapython
ipapython depends on ipaplatform

https://github.com/freeipa/freeipa/blob/master/ipaplatform/setup.py#L49
https://github.com/freeipa/freeipa/blob/master/ipapython/setup.py#L44

@adisbladis
Copy link
Member

This is not really a Poetry2nix question, but more of a "How to package Python with Nix" question.
This needs to be solved in nixpkgs.

See NixOS/nixpkgs#272178 for more context regarding the nixpkgs architecture and a potential solution to circular dependencies.

@patryk4815
Copy link
Contributor Author

patryk4815 commented Dec 29, 2023

@adisbladis Poetry2nix can resolve circular dependencies by skipping them, and even if the installation in the virtual environment doesn't have a proper graph, it should still work fine.

Circular dependencies are typically required only at runtime, not during the build process. Thus, for poetry2nix.venv, skipping such dependencies should pose no issues.

Or I'm missing something?

why should we be concerned about having a one-to-one proper graph in this context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants