Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure computer and server folders. #223

Open
soupglasses opened this issue Aug 21, 2023 · 4 comments
Open

Restructure computer and server folders. #223

soupglasses opened this issue Aug 21, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@soupglasses
Copy link

Is your feature request related to a problem? Please describe.

Currently a lot of folders inside ./nixos follows a set of "concepts" so to say, like hardware, mixins, modules, and roles. It seems out of place that the default configs for servers and computers are put into this top level, especially since they are both essentially single files of default.nix.

Describe the solution you'd like

This is very much up in the air, and very much for discussion. But something among the lines of ./nixos/kind/server.nix or ./nixos/kinds/computer/default.nix could be a better structure here to follow the idea of having top level "concepts".

Describe alternatives you've considered

Continuing having the ./nixos/computer and ./nixos/server folders.

Additional context

@soupglasses soupglasses added the enhancement New feature or request label Aug 21, 2023
@Mic92
Copy link
Member

Mic92 commented Aug 22, 2023

Changing this now would break the import paths. srvos.nixosModules.server is bascially the default import for all servers.

@soupglasses
Copy link
Author

One could also add back the module names as aliases too. Either with or without a trace warning, or simply have them as top level without any kind of kind- prefix.

I am primarily focused on the folder structure, and do not see a problem with the name of nixosModules.server itself.

@zimbatm
Copy link
Member

zimbatm commented Aug 23, 2023

What is the computer one referring to? We have "server", "desktop" and "common".

I understand the tension but would rather keep the folder structure as shallow as possible. If we add more "kinds" of machines then it would make sense to create that folder.

@soupglasses
Copy link
Author

Yeah sorry. When I stated computer I was thinking about desktop. Sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants