fix: biome linter fixes

Author: jnoortheen

.husky/pre-commit

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname $0)/_/husky.sh"
-
-yarn pretty-quick --staged
+bun lint

biome.json

@@ -1,31 +1,33 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
-  "vcs": {
-    "enabled": true,
-    "clientKind": "git",
-    "useIgnoreFile": true
-  },
-  "files": {
-    "ignoreUnknown": false,
-    "ignore": []
-  },
-  "formatter": {
-    "enabled": true,
-    "indentStyle": "tab"
-  },
-  "organizeImports": {
-    "enabled": true
-  },
-  "linter": {
-    "enabled": true,
-    "rules": {
-      "recommended": true
-    }
-  },
-  "javascript": {
-    "formatter": {
-      "quoteStyle": "double"
-    },
-    "globals": ["exports"]
-  }
-}
+	"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+	"vcs": {
+		"enabled": true,
+		"clientKind": "git",
+		"useIgnoreFile": true
+	},
+	"files": {
+		"ignoreUnknown": false,
+		"ignore": []
+	},
+	"formatter": {
+		"enabled": true,
+		"indentStyle": "space"
+	},
+	"organizeImports": {
+		"enabled": true
+	},
+	"linter": {
+		"enabled": true,
+		"rules": {
+			"recommended": true
+		}
+	},
+	"javascript": {
+		"formatter": {
+			"quoteStyle": "double"
+		},
+		"globals": [
+			"exports"
+		]
+	}
+}

src/client.ts

@@ -1,28 +1,29 @@
 // from PR of https://github.com/nix-community/vscode-nix-ide/pull/16/
 
+// biome-ignore lint/style/useNodejsImportProtocol: <explanation>
+import { inspect } from "util";
+import { sync as commandExistsSync } from "command-exists";
 import {
-  env,
-  ExtensionContext,
+  type Disposable,
+  type ExtensionContext,
   Uri,
+  env,
   window,
   workspace,
-  Disposable,
 } from "vscode";
-import {
-  LanguageClientOptions,
-  LSPArray,
+import type {
+  CancellationToken,
   ConfigurationParams,
+  LSPArray,
+  LanguageClientOptions,
   MessageSignature,
-  CancellationToken,
 } from "vscode-languageclient";
 import {
-  Executable,
+  type Executable,
   LanguageClient,
-  ServerOptions,
+  type ServerOptions,
 } from "vscode-languageclient/node";
-import { config, UriMessageItem } from "./configuration";
-import { sync as commandExistsSync } from "command-exists";
-import { inspect } from "util";
+import { type UriMessageItem, config } from "./configuration";
 
 class Client extends LanguageClient {
   disposables: Disposable[] = [];
@@ -52,7 +53,9 @@ class Client extends LanguageClient {
   override dispose(timeout?: number): Promise<void> {
     let timedOut = false;
     if (timeout) {
-      setTimeout(() => (timedOut = true), timeout);
+      setTimeout(() => {
+        timedOut = true;
+      }, timeout);
     }
 
     for (const disposable of this.disposables) {
@@ -131,8 +134,8 @@ export async function activate(context: ExtensionContext): Promise<void> {
   context.subscriptions.push(client);
 }
 
-export async function deactivate(): Promise<void | undefined> {
-  if (client && client.needsStop()) {
+export async function deactivate(): Promise<void> {
+  if (client?.needsStop()) {
     await client.stop();
   }
   await client.dispose();

src/configuration.ts

@@ -1,11 +1,11 @@
 import {
-  ConfigurationChangeEvent,
-  WorkspaceConfiguration,
+  type ConfigurationChangeEvent,
+  type WorkspaceConfiguration,
   workspace,
 } from "vscode";
-import { LSPObject } from "vscode-languageclient";
+import type { LSPObject } from "vscode-languageclient";
 
-import { MessageItem, Uri } from "vscode";
+import type { MessageItem, Uri } from "vscode";
 import { transformConfigValueByVscodeVariables } from "./utils";
 
 export interface UriMessageItem extends MessageItem {

src/extension.ts

@@ -1,9 +1,9 @@
 import * as vscode from "vscode";
-import { ExtensionContext } from "vscode";
+import type { ExtensionContext } from "vscode";
+import * as client from "./client";
+import { config } from "./configuration";
 import { formattingProviders } from "./formatter";
 import { startLinting } from "./linter";
-import { config } from "./configuration";
-import * as client from "./client";
 
 /**
  * Activate this extension.

src/formatter.ts

@@ -1,18 +1,17 @@
 import * as vscode from "vscode";
 import {
-  DocumentFormattingEditProvider,
-  DocumentRangeFormattingEditProvider,
+  type DocumentFormattingEditProvider,
+  type DocumentRangeFormattingEditProvider,
   Range,
-  TextDocument,
+  type TextDocument,
   TextEdit,
 } from "vscode";
-import { IProcessResult, runInWorkspace } from "./process-runner";
 import { config } from "./configuration";
+import { type IProcessResult, runInWorkspace } from "./process-runner";
 
-const FORMATTER: Array<string> =
-  config.formatterPath instanceof Array
-    ? config.formatterPath
-    : [config.formatterPath];
+const FORMATTER: Array<string> = Array.isArray(config.formatterPath)
+  ? config.formatterPath
+  : [config.formatterPath];
 
 /**
  * Get text edits to format a range in a document.
@@ -23,25 +22,25 @@ const FORMATTER: Array<string> =
  */
 const getFormatRangeEdits = async (
   document: TextDocument,
-  range?: Range
+  range?: Range,
 ): Promise<ReadonlyArray<TextEdit>> => {
   const actualRange = document.validateRange(
-    range || new Range(0, 0, Number.MAX_VALUE, Number.MAX_VALUE)
+    range || new Range(0, 0, Number.MAX_VALUE, Number.MAX_VALUE),
   );
   let result: IProcessResult;
   try {
-    FORMATTER.forEach(
-      (elm, i) => (FORMATTER[i] = elm.replace("{file}", document.fileName))
-    );
+    FORMATTER.forEach((elm, i) => {
+      FORMATTER[i] = elm.replace("{file}", document.fileName);
+    });
     result = await runInWorkspace(
       vscode.workspace.getWorkspaceFolder(document.uri),
       FORMATTER,
-      document.getText(actualRange)
+      document.getText(actualRange),
     );
   } catch (error) {
     if (error instanceof Error) {
       await vscode.window.showErrorMessage(
-        `Failed to run ${FORMATTER.join(" ")}: ${error.message}`
+        `Failed to run ${FORMATTER.join(" ")}: ${error.message}`,
       );
     }
     // Re-throw the error to make the promise fail
@@ -67,13 +66,13 @@ export const formattingProviders: FormattingProviders = {
       token.isCancellationRequested
         ? []
         : // tslint:disable-next-line:readonly-array
-          (edits as TextEdit[])
+          (edits as TextEdit[]),
     ),
   provideDocumentRangeFormattingEdits: (document, range, _, token) =>
     getFormatRangeEdits(document, range).then((edits) =>
       token.isCancellationRequested
         ? []
         : // tslint:disable-next-line:readonly-array
-          (edits as TextEdit[])
+          (edits as TextEdit[]),
     ),
 };

src/linter.ts

@@ -1,7 +1,5 @@
-"use strict";
-
 import * as vscode from "vscode";
-import { Diagnostic, ExtensionContext, TextDocument } from "vscode";
+import { Diagnostic, type ExtensionContext, type TextDocument } from "vscode";
 import { runInWorkspace } from "./process-runner";
 
 /**
@@ -18,7 +16,7 @@ const isSavedDocument = (document: TextDocument): boolean =>
         language: "nix",
         scheme: "file",
       },
-      document
+      document,
     );
 
 interface LintErrorType {
@@ -45,8 +43,8 @@ const getErrors = (text: string): ReadonlyArray<LintErrorType> => {
   while (match !== null) {
     results.push({
       msg: match[1],
-      row: parseInt(match[2]),
-      col: parseInt(match[3]),
+      row: Number.parseInt(match[2]),
+      col: Number.parseInt(match[3]),
     });
     match = pattern.exec(text);
   }
@@ -62,12 +60,12 @@ const getErrors = (text: string): ReadonlyArray<LintErrorType> => {
  */
 const shellOutputToDiagnostics = (
   document: TextDocument,
-  output: string
+  output: string,
 ): ReadonlyArray<Diagnostic> => {
   const diagnostics: Array<Diagnostic> = [];
   for (const err of getErrors(output)) {
     const range = document.validateRange(
-      new vscode.Range(err.row - 1, err.col - 2, err.row - 1, err.col + 2)
+      new vscode.Range(err.row - 1, err.col - 2, err.row - 1, err.col + 2),
     );
     const diagnostic = new Diagnostic(range, err.msg);
     diagnostic.source = "nix";
@@ -88,7 +86,7 @@ export async function startLinting(context: ExtensionContext): Promise<void> {
   const lint = async (document: TextDocument) => {
     if (isSavedDocument(document)) {
       const workspaceFolder = vscode.workspace.getWorkspaceFolder(document.uri);
-      let d: ReadonlyArray<Diagnostic>
+      let d: ReadonlyArray<Diagnostic>;
       try {
         const result = await runInWorkspace(workspaceFolder, [
           "nix-instantiate",
@@ -116,6 +114,6 @@ export async function startLinting(context: ExtensionContext): Promise<void> {
   vscode.workspace.onDidCloseTextDocument(
     (d) => diagnostics.delete(d.uri),
     null,
-    context.subscriptions
+    context.subscriptions,
   );
-};
+}

src/process-runner.ts

@@ -1,5 +1,5 @@
-import { execFile } from "child_process";
-import { WorkspaceFolder } from "vscode";
+import { execFile } from "node:child_process";
+import type { WorkspaceFolder } from "vscode";
 
 /**
  * A system error, i.e. an error that results from a syscall.

src/utils.ts

@@ -1,4 +1,4 @@
-import { LSPObject } from "vscode-languageclient";
+import type { LSPObject } from "vscode-languageclient";
 import variables from "vscode-variables";
 
 /**
@@ -15,12 +15,9 @@ export const transformConfigValueByVscodeVariables = <
     if (typeof cfg === "string") {
       cfg = variables(cfg) as T;
     } else if (!!cfg && typeof cfg === "object") {
-      Object.keys(cfg).forEach((key) => {
-        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-        // @ts-ignore
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      for (const key of Object.keys(cfg)) {
         cfg[key] = transformConfigValueByVscodeVariables(cfg[key]);
-      });
+      }
     } else if (Array.isArray(cfg) && cfg.length > 0) {
       cfg = cfg.map(
         (item) => transformConfigValueByVscodeVariables(item) as unknown,