Skip to content

Show library license #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s-celles opened this issue May 13, 2018 · 9 comments
Closed

Show library license #5

s-celles opened this issue May 13, 2018 · 9 comments

Comments

@s-celles
Copy link

Hello,

Arduino libraries should display library license
Related issue arduino/Arduino#6646

Kind regards

@njh
Copy link
Owner

njh commented May 21, 2018

Is this dependant on it appearing in the Library Manager JSON?

Or are you asking me to do the license detection myself?

@s-celles
Copy link
Author

My opinion is that it should be managed upstream ie in Arduino JSON http://downloads.arduino.cc/libraries/library_index.json

But if you are able to autodetect license it could help to fix upstream issue.

Unfortunately several problems are linked...

The more problematic being arduino/Arduino#7591

I opened this issue just to inform you about current situation...

@njh
Copy link
Owner

njh commented May 25, 2018

Added licence to each of the the library pages in 205d328.

Currently waiting for the site to rebuild.

@njh
Copy link
Owner

njh commented May 26, 2018

Had some problems rebuilding the site. I think I am going to have to re-write the way is stores the data/builds the pages.

If the license has been given in library.properties, it shows that. Otherwise it falls back the to GitHub detected license.

Example page:
https://www.arduinolibraries.info/libraries/arduino-json

License MIT

Is this what you had in mind?

@s-celles
Copy link
Author

https://www.arduinolibraries.info/libraries/embedded-template-library license is not recognised.
https://github.com/ETLCPP/etl have a LICENSE file which shows it's MIT licensed.

@s-celles
Copy link
Author

@njh
Copy link
Owner

njh commented May 29, 2018

This ticket is about the rendering of the information, not the detection of licenses.

The ETLCPP license file isn't being detected by GitHub. I am not sure how the GitHub license detector works but it is probably due to customisations in the LICENSE file - it might be the links that have been added after the copyright line.

When a license is detected by GitHub, then it displays in the bar at the top of the project:
screenshot 2018-05-29 08 57 45

The only other change I am planning to make it adding the license to the Linked Data.

@njh
Copy link
Owner

njh commented May 30, 2018

license is now also appearing in the JSON-LD:
https://www.arduinolibraries.info/libraries/arduino-json.json

@njh njh closed this as completed May 30, 2018
@s-celles
Copy link
Author

Thanks @njh

@s-celles s-celles mentioned this issue May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants