|
1 |
| -{{#if claEnabled}} |
2 |
| -{{#if askForCla}} |
3 |
| -[](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla) |
| 1 | +{{#if askAboutContributors}} |
| 2 | +Thank you so much for the pull request @{{ userName }}! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! |
4 | 3 |
|
5 |
| -Welcome to the Cesium community @{{ userName }}! |
| 4 | +The [Pull Request Guidelines](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#pull-request-guidelines) is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that. |
6 | 5 |
|
7 |
| -Can you please send in a [Contributor License Agreement](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla) (CLA) so that we can review and merge this pull request? |
| 6 | +* :x: Missing `CONTRIBUTORS.md` entry. |
| 7 | + * Please add yourself to the [contributors]({{ contributorsUrl }}) file! |
8 | 8 | {{else}}
|
9 |
| - |
10 |
| - |
11 |
| -@{{ userName }}, thanks for the pull request! Maintainers, we have a signed CLA from @{{ userName }}, so you can review this at any time. |
| 9 | +Thanks for the pull request @{{ userName }}! |
12 | 10 | {{/if}}
|
| 11 | +{{#if claEnabled}} |
| 12 | +{{#if errorCla}} |
| 13 | +* :grey_exclamation: There was an error checking the CLA! If this is your first contribution, please send in a [Contributor License Agreement](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla). |
| 14 | + * Maintainers, this was the error I ran into while attempting to process the CLA check. Please resolve it to continue CLA checking. |
| 15 | + ``` |
| 16 | + {{ errorCla }} |
| 17 | + ``` |
13 | 18 | {{else}}
|
14 |
| -@{{ userName }}, thanks for the pull request! |
| 19 | +{{#if askForCla}} |
| 20 | +* :x: Missing CLA. |
| 21 | + * Please send in a [Contributor License Agreement](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla) (CLA) and comment back here to let us know to check this! |
| 22 | +{{else}} |
| 23 | +* :heavy_check_mark: Signed CLA found. |
| 24 | +{{/if}} |
| 25 | +{{/if}} |
15 | 26 | {{/if}}
|
16 |
| - |
17 | 27 | {{#if askAboutChanges}}
|
18 |
| -:warning: I noticed that [CHANGES.md]({{ repository_url }}/blob/master/CHANGES.md) has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to `CHANGES.md` and comment on this pull request so we know it was updated. For more info, see the [Pull Request Guidelines]( https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#pull-request-guidelines). |
19 |
| - |
| 28 | +* :grey_question: [CHANGES.md]({{ repository_url }}/blob/{{ headBranch }}/CHANGES.md) was not updated. |
| 29 | + * If this change updates the public API in any way, please add a bullet point to `CHANGES.md`. |
20 | 30 | {{/if}}
|
21 | 31 | {{#if askAboutThirdParty}}
|
22 |
| -:warning: I noticed that a file in one of our ThirdParty folders (`{{ thirdPartyFolders }}`) has been added or modified. Please verify that it has a section in [LICENSE.md]({{ repository_url }}/blob/master/LICENSE.md) and that its license information is up to date with this new version. Once you do, please confirm by commenting on this pull request. |
23 |
| - |
| 32 | +* :grey_question: Changes to third party files were made. |
| 33 | + * Looks like a file in one of our ThirdParty folders (`{{ thirdPartyFolders }}`) has been added or modified. Please verify that it has a section in [LICENSE.md]({{ repository_url }}/blob/master/LICENSE.md) and that its license information is up to date with this new version. |
24 | 34 | {{/if}}
|
| 35 | +{{#if askAboutTests}} |
| 36 | +* :grey_question: Unit tests were not updated. |
| 37 | + * Make sure you've [updated tests](https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/TestingGuide) to reflect your changes, added tests for any new code, and ran the code coverage tool. |
| 38 | +{{/if}} |
| 39 | + |
| 40 | +Reviewers, don't forget to make sure that: |
| 41 | + |
| 42 | +- [ ] Cesium Viewer works. |
| 43 | +- [ ] Works in 2D/CV. |
| 44 | +- [ ] Works (or fails gracefully) in IE11. |
0 commit comments