Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all supported r-spatial packages to Suggests #10

Closed
Aariq opened this issue Mar 11, 2024 · 0 comments · Fixed by #35
Closed

Move all supported r-spatial packages to Suggests #10

Aariq opened this issue Mar 11, 2024 · 0 comments · Fixed by #35

Comments

@Aariq
Copy link
Collaborator

Aariq commented Mar 11, 2024

In #4 @brownag mentioned moving terra and other r-spatial packages from Imports to Suggests, and I think this is a good call. We shouldn't require users to have all supported r-spatial packages installed just to use targets with one of them. rlang::check_installed() prompts users to install a missing package and installs it for them, but since this code will mostly be run in a callr environment, it might be more appropriate to just use rlang::is_installed(). We could even supply a custom tip like

! package terra is required.
Did you forget to add "terra" to tar_option_set(packages = ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant