Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android reveals clipboard sensitive items #189

Open
nelsonjr opened this issue Dec 19, 2022 · 6 comments
Open

Android reveals clipboard sensitive items #189

nelsonjr opened this issue Dec 19, 2022 · 6 comments

Comments

@nelsonjr
Copy link

On Android, all copies to clipboards are displayed on the screen. If this component is used to copy passwords, they are displayed on the screen, which is not ideal.

Please add the ability to mark content as sensitive so that it does not display what it copied when the component activates.

References:

@nkbt
Copy link
Owner

nkbt commented Dec 19, 2022

  1. This is a react component, not an android lib.
  2. I do not do dev for android and don't have a single android phone around. Cannot help much.
  3. Please add a codepen with the way to reproduce the issue and/or send pull request with the fix

@nkbt
Copy link
Owner

nkbt commented Dec 19, 2022

alternatively just don't use copy to clipboard for passwords

@nelsonjr
Copy link
Author

Thanks for the prompt response. I will do some research and see if I can help improve your great library.

FYI, password managers use the clipboard to save the password so you can paste in forms.

@nkbt
Copy link
Owner

nkbt commented Dec 21, 2022

Thanks.

(I am using passwords managers since mid 2000s, so yeah they do copy) What I meant was not to use this library to copy passwords. You have to 1. intentionally add a button to copy and 2. click on it to copy value.
I do not believe it can accidentally copy and reveal your password

@nelsonjr
Copy link
Author

I am using your library as I am building a password manager. I will keep you posted on what I find.

In Android 13, the clipboard preview shows it:
image

@nkbt
Copy link
Owner

nkbt commented Dec 22, 2022

Ah okay, makes sense then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants