-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix componentWIllReceiveProps warning #41
Comments
If you are using react-height directly - yeah, it is the case. If as part of react-collapse - then I suggest upgrading react-collapse, latest version does not depend on react-height and react-motion. |
@nkbt thanks for the pointer, I'm indeed using older version of react-collapse because of some issues with the newer version. |
Sure, no worries. It’s not that easy though. Look through the source for some ideas. Cheers, and happy new 2020 from Sydney 🎉 |
Thanks, I surely will! |
@nkbt are you open for a small PR to rename this to |
Surely |
what is the status of this PR? i think React 18 will come soon |
Currently this package triggers React's warnings:
At the very least we can rename this method to
UNSAFE_componentWIllReceiveProps
or better yet fix it properly.The text was updated successfully, but these errors were encountered: