Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix componentWIllReceiveProps warning #41

Open
dimaip opened this issue Dec 27, 2019 · 7 comments
Open

Fix componentWIllReceiveProps warning #41

dimaip opened this issue Dec 27, 2019 · 7 comments

Comments

@dimaip
Copy link

dimaip commented Dec 27, 2019

Currently this package triggers React's warnings:

image

At the very least we can rename this method to UNSAFE_componentWIllReceiveProps or better yet fix it properly.

@nkbt
Copy link
Owner

nkbt commented Dec 30, 2019

If you are using react-height directly - yeah, it is the case. If as part of react-collapse - then I suggest upgrading react-collapse, latest version does not depend on react-height and react-motion.

@dimaip
Copy link
Author

dimaip commented Dec 31, 2019

@nkbt thanks for the pointer, I'm indeed using older version of react-collapse because of some issues with the newer version.
Perhaps I will just re-write this component myself for my project.

@nkbt
Copy link
Owner

nkbt commented Dec 31, 2019

Sure, no worries. It’s not that easy though. Look through the source for some ideas.

Cheers, and happy new 2020 from Sydney 🎉

@dimaip
Copy link
Author

dimaip commented Dec 31, 2019

Thanks, I surely will!
Happy new year from Moscow!

@rogerfar
Copy link

@nkbt are you open for a small PR to rename this to UNSAFE_componentWillReceiveProps? I know 18 isn't around the corner just yet, but at least it will get rid of the pesky warning.

@nkbt
Copy link
Owner

nkbt commented May 29, 2021

Surely

@vtrphan
Copy link

vtrphan commented Feb 1, 2022

what is the status of this PR? i think React 18 will come soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants