Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra ./node_modules/ folder created just for .vinxi when used with bun workspaces #320

Open
birkskyum opened this issue Jun 26, 2024 · 2 comments

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Jun 26, 2024

In a monorepo (bun workspaces), when running the dev server a new node_modules/ folder is created inside my solidstart app package, just to accommodate a nested .vinxi folder as shown below

Screenshot 2024-06-26 at 17 15 46

When building, a .vinxi folder is created at the same level as the node_modules folder, so now there are two .vinxi folders...

Screenshot 2024-06-26 at 17 18 07

It doesn't really makes sense to create an extra node_modules folder just for vinxi

@birkskyum birkskyum changed the title Stuff is saved to ./node_modules/.vinxi Extra ./node_modules/ folder created just for .vinxi Jun 26, 2024
@birkskyum
Copy link
Contributor Author

birkskyum commented Nov 10, 2024

This issue appear somewhat bun-specific, since other package managers doesn't hoist to the same extend

@birkskyum birkskyum changed the title Extra ./node_modules/ folder created just for .vinxi Extra ./node_modules/ folder created just for .vinxi with bun Nov 10, 2024
@birkskyum birkskyum changed the title Extra ./node_modules/ folder created just for .vinxi with bun Extra ./node_modules/ folder created just for .vinxi when used with bun Nov 10, 2024
@birkskyum birkskyum changed the title Extra ./node_modules/ folder created just for .vinxi when used with bun Extra ./node_modules/ folder created just for .vinxi when used with bun workspaces Nov 10, 2024
@nksaraf
Copy link
Owner

nksaraf commented Dec 1, 2024

those must be the vite caches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants