Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: @vanilla-extract/vite-plugin causes errors in console during build's transform solidjs/solid-start#1224 #98

Closed
nksaraf opened this issue Jan 6, 2024 · 6 comments

Comments

@nksaraf
Copy link
Owner

nksaraf commented Jan 6, 2024

No description provided.

@Nvos
Copy link
Contributor

Nvos commented Feb 29, 2024

Reproduction

https://github.com/Nvos/vanilla-extract-vinxi-repro

Pretty much solid start scaffold with added vanilla extract vite plugin, just do pnpm dev and navigate to app via URL

Notes

  • Error happens when importing vanilla extract files *.css.ts
  • Took look at vanilla extract and it seems that error happens for relative path files (vanilla extract ones), during dev it seems that there's both relative and absolute path file being resolved and relative one fails due to vanilla extract cache containing absolute path key
  • Happens only during dev after navigation to page containing vanilla-extract import
  • Seems to be working on production build
  • Happens only during SSR

@nksaraf
Copy link
Owner Author

nksaraf commented Mar 2, 2024

I am trying to run this and its working fine without errors. Do i need to add any files or make any changes to see this error? Can you put in a screen recording with the error so i can see how to reproduce it. Can you also try running this with latest vinxi 0.3.8 and see if its fine or not.

@Nvos
Copy link
Contributor

Nvos commented Mar 2, 2024

Seems that issue is present on latest version of vinxi as well, thought checked out if it happens on linux and it seems to work on it. So it seems to be relevant to windows only.

@nksaraf
Copy link
Owner Author

nksaraf commented Mar 2, 2024

ahh okay windows issue.. maybe we can add a test on windows for this or somebody can try to debug this on windows ( i usually don't have access to a windows system)

@Nvos
Copy link
Contributor

Nvos commented Mar 5, 2024

After some debugging issue seems to be related to vanilla-extract in code related to absolute path resolution, opened issue on their repo vanilla-extract-css/vanilla-extract#1344

@nksaraf
Copy link
Owner Author

nksaraf commented Mar 5, 2024

Ahh great okay makes sense. I'll close this for now then. If anything goes wrong agin feel free to open this

@nksaraf nksaraf closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants