Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Link component #389

Merged
merged 14 commits into from
Dec 20, 2024
Merged

feat: add Link component #389

merged 14 commits into from
Dec 20, 2024

Conversation

Yolijn
Copy link
Member

@Yolijn Yolijn commented Dec 16, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:21pm
candidate-storybook-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:21pm
evil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:21pm

@Yolijn Yolijn marked this pull request as draft December 16, 2024 21:29
Robbert
Robbert requested changes Dec 16, 2024
View reviewed changes
packages/common-css/focus-css/README.md Outdated Show resolved Hide resolved
packages/common-css/focus-css/package.json Outdated Show resolved Hide resolved
packages/common-css/focus-css/src/_mixin.scss Outdated Show resolved Hide resolved
packages/storybook-test/stories/link/link.stories.tsx Outdated Show resolved Hide resolved
packages/storybook-test/stories/link/link.stories.tsx Outdated Show resolved Hide resolved
packages/storybook-test/stories/link/link.stories.tsx Show resolved Hide resolved
packages/storybook-test/stories/link/link.stories.tsx Show resolved Hide resolved
Robbert
Robbert requested changes Dec 16, 2024
View reviewed changes
packages/tokens/focus-tokens/tokens.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3291c3f) to head (7a991e0).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          346       391   +45     
  Branches        28        33    +5     
=========================================
+ Hits           346       391   +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matijs matijs changed the title Feat/add link css Feat: Add link CSS Dec 19, 2024
@Robbert Robbert changed the title Feat: Add link CSS feat: add Link component Dec 20, 2024
@Robbert Robbert enabled auto-merge (squash) December 20, 2024 11:37
@matijs matijs mentioned this pull request Dec 20, 2024
Closed
@Robbert Robbert merged commit c586663 into main Dec 20, 2024
10 of 11 checks passed
@Robbert Robbert deleted the feat/add-link-css branch December 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matijs matijs matijs left review comments

@Robbert Robbert Robbert approved these changes

@MarjonBakker MarjonBakker Awaiting requested review from MarjonBakker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link - Candidate NLDS - A11y getest
4 participants
@Yolijn @codecov-commenter @Robbert @matijs