Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependencies #430

Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore: dependencies #430

merged 1 commit into from
Feb 5, 2025

Conversation

matijs
Copy link
Member

@matijs matijs commented Jan 31, 2025

Update dependencies.

react, react-dom, @types/react, and @types/react-dom are kept on v18 for now

Update @nl-design-system/eslint-config to 1.0.0 and fix linting issues

Closes #426

@matijs matijs requested a review from Robbert January 31, 2025 11:05
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:18am
candidate-storybook-non-conforming ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:18am
candidate-storybook-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:18am
evil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:18am

Copy link

Uh oh! @sonarqubecloud[bot], the image you shared is missing helpful alt text. Check #430 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (364f023) to head (75a1b96).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          391       391           
  Branches        34        35    +1     
=========================================
  Hits           391       391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update dependencies.

react, react-dom, @types/react, and @types/react-dom are kept on v18 for
now

Update @nl-design-system/eslint-config to 1.0.0 and fix linting issues
@matijs matijs force-pushed the chore/dependencies branch from a7641ad to 75a1b96 Compare February 5, 2025 11:13
@matijs matijs enabled auto-merge (rebase) February 5, 2025 11:13
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link

github-actions bot commented Feb 5, 2025

Uh oh! @sonarqubecloud[bot], at least one image you shared is missing helpful alt text. Check #430 (comment) to fix the following violations:

  • Images should have alternate text (alt text) at line 3
  • Images should have alternate text (alt text) at line 4
  • Images should have alternate text (alt text) at line 7
  • Images should have alternate text (alt text) at line 8
  • Images should have alternate text (alt text) at line 9

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@matijs matijs merged commit 97bf917 into main Feb 5, 2025
14 checks passed
@matijs matijs deleted the chore/dependencies branch February 5, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants