Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form field error message #240

Closed
8 tasks
MrSkippy opened this issue Sep 24, 2024 · 2 comments · Fixed by #306
Closed
8 tasks

Form field error message #240

MrSkippy opened this issue Sep 24, 2024 · 2 comments · Fixed by #306
Assignees
Labels
new component Adding a new component to the library react Issue involving a ReactJS component

Comments

@MrSkippy
Copy link
Contributor

MrSkippy commented Sep 24, 2024

Omschrijving

Image

Aanpak

Voorstel Robbert:

  • PR bij Utrecht maken om 'm de features te geven van alert
  • nieuwe versie van Utrecht component in gebruik nemen bij RHC
  • Ik zou de Utrecht error message wrappen in Lux en de icon instellen op basis van danger/.../...

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken (zie ook Testing components)
  • Visual regression test (door LUX)

Repository

LUX

Links

LUX

NLDS

@MrSkippy MrSkippy converted this from a draft issue Sep 24, 2024
@rwittenberns
Copy link
Contributor

In NLDS community dev channel discussie openen hoe we onze gewenste features (border radius, background color en icon) kunnen toevoegen, en of dat het beste bij Utrecht of RHC kan.

@rwittenberns rwittenberns assigned remypar5 and MrSkippy and unassigned remypar5 Sep 24, 2024
@MrSkippy MrSkippy mentioned this issue Oct 1, 2024
8 tasks
@MrSkippy MrSkippy added new component Adding a new component to the library react Issue involving a ReactJS component labels Oct 1, 2024
@MrSkippy MrSkippy removed their assignment Oct 8, 2024
@VladAfanasev VladAfanasev self-assigned this Oct 9, 2024
@MrSkippy MrSkippy linked a pull request Oct 21, 2024 that will close this issue
3 tasks
@AlineNap
Copy link
Contributor

AlineNap commented Nov 6, 2024

Design review 6 November

Vragen documentatie

  1. Wat doet de property distance precies? Is daar een design token voor oid? Welke margin krijgt hij dan toebedeeld?
  2. Waarom zit de property distance niet in de playground description en wel bij de error message? Utrecht heeft ze op beide componenten als ik hun Storybook bekijk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Adding a new component to the library react Issue involving a ReactJS component
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants