Refactor: split methods, docs, error handling, smaller methodes and consistency

[304NotModified]

No description provided.

[snakefoot]

Looks like it is matching the condition just above

[304NotModified]

yes indeed, was also thinking to refactor that

(note I only moved the check)

[304NotModified]

refactored :)

[snakefoot]

Like this better.

if (string.IsNullOrEmpty(paramPair.Key))
      continue;

if (paramPair.Key != NLogLogger.OriginalFormatPropertyName || i == parameterList.Count - 1)
{

[304NotModified]

Like this better.

if (string.IsNullOrEmpty(paramPair.Key))
continue;

if (paramPair.Key != NLogLogger.OriginalFormatPropertyName || i == parameterList.Count - 1)
{

Then we need still the 2nd (duplicate) check ?

[snakefoot]

Then we need still the 2nd (duplicate) check ?

Yes you are right. The code validates that that the parameters comes in the expected order. And if not, then allocates the validParameterList.

I guess the code code should be extracted to method called. CreateValidParameterList(). Where the comment for the method is that it expects the parameters to be non-empty and that the last parameter is the original-format-string.

Little confusing that the validation and the creation of the "valid" parameter list is the same method. Guess I was lazy when I wrote the code.

[304NotModified]

@snakefoot did I broke the atomic update? See https://travis-ci.org/NLog/NLog.Extensions.Logging/builds/310224901?utm_source=github_status&utm_medium=notification

[304NotModified]

ow found it :)

[304NotModified]

I guess the code code should be extracted to method called. CreateValidParameterList(). Where the comment for the method is that it expects the parameters to be non-empty and that the last parameter is the original-format-string.

Little confusing that the validation and the creation of the "valid" parameter list is the same method. Guess I was lazy when I wrote the code.

@snakefoot could you please create a PR for this? :)

[snakefoot]

@snakefoot could you please create a PR for this? :)

Created #180 for you