Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NLog dependency, exclude NLog 5 pre-releases #217

Merged
merged 1 commit into from
May 9, 2018
Merged

Update NLog dependency, exclude NLog 5 pre-releases #217

merged 1 commit into from
May 9, 2018

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented May 9, 2018 •
edited
Loading

fixes #216, thanks @aweebs!

@304NotModified 304NotModified added this to the 1.0.2 milestone May 9, 2018
@304NotModified 304NotModified mentioned this pull request May 9, 2018
Closed
@304NotModified 304NotModified changed the title Update range Update range, exclude NLog 5 pre-releases May 9, 2018
@304NotModified 304NotModified changed the title Update range, exclude NLog 5 pre-releases Update NLog dependency, exclude NLog 5 pre-releases May 9, 2018
@304NotModified
Copy link
Member Author

looks good to me

image

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #217 into master will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage    59.4%   58.97%   -0.43%     
==========================================
  Files           6        6              
  Lines         234      234              
  Branches       45       45              
==========================================
- Hits          139      138       -1     
  Misses         74       74              
- Partials       21       22       +1
Impacted Files Coverage Δ
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 91.42% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a49b77...1dfc9ee. Read the comment docs.

@304NotModified 304NotModified merged commit b2f6076 into master May 9, 2018
@304NotModified 304NotModified deleted the fix-dep-range branch May 9, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Update nuget package references to properly exclude NLog 5.0.0
1 participant
@304NotModified