Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vulnerable dependency #150

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

johnkors
Copy link
Contributor

@johnkors johnkors commented Jun 9, 2017

Hi, re: https://github.com/dotnet/corefx/issues/19535

I scanned Nlog.Web.AspNetCore using dotnet retire and found use of a vulnerable dependency. This PR bumps the package that brings this dependency in.

image

Dependency chain resulting in use of vulnerable dependency System.Text.Encodings.Web/4.0.0 :

Microsoft.AspNetCore.Routing.Abstractions/1.0.3
=>
Microsoft.AspNetCore.Http.Abstractions/1.0.2
=>
System.Text.Encodings.Web/4.0.0

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #150   +/-   ##
======================================
  Coverage    57.7%   57.7%           
======================================
  Files          29      29           
  Lines         383     383           
  Branches       92      92           
======================================
  Hits          221     221           
  Misses        125     125           
  Partials       37      37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f93f9f...f7f3779. Read the comment docs.

@304NotModified
Copy link
Member

ah cool thanks!

Could you also analyse NLog.extensions.Logging and NLog? Or isn't that needed?

@304NotModified 304NotModified merged commit 63b05ff into NLog:master Jun 9, 2017
@304NotModified 304NotModified added this to the NLog.Web.AspNetCore 4.4.1 milestone Jun 9, 2017
@johnkors
Copy link
Contributor Author

johnkors commented Jun 9, 2017

NLog.Web.AspNetCore references these other two projects, so AFAIK - any dependency they bring in would also be present for analysis (it checks the /obj/project.assets.json file of .NET Core projects). So I think they're already checked :)

@304NotModified
Copy link
Member

oops,we broke the build but AppVeyor showing green.

@304NotModified 304NotModified mentioned this pull request Jun 9, 2017
@304NotModified 304NotModified modified the milestones: NLog.Web.AspNetCore 4.4.1 + NLog.Web 4.5.1, NLog.Web.AspNetCore 4.5 + NLog.Web 4.5.1 Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants