Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP.NET Core 2 support #178

Merged
merged 1 commit into from
Sep 29, 2017
Merged

ASP.NET Core 2 support #178

merged 1 commit into from
Sep 29, 2017

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Sep 29, 2017 •
edited
Loading

fixes #168

@codecov
Copy link

codecov bot commented Sep 29, 2017 •
edited
Loading

Codecov Report

Merging #178 into master will decrease coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   58.18%   57.66%   -0.52%     
==========================================
  Files          29       29              
  Lines         385      385              
  Branches       93       93              
==========================================
- Hits          224      222       -2     
  Misses        125      125              
- Partials       36       38       +2
Impacted Files Coverage Δ
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 25% <ø> (ø) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 80.76% <0%> (-3.85%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 95.12% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20351a9...6fa5352. Read the comment docs.

@304NotModified 304NotModified force-pushed the aspnetcore2 branch 3 times, most recently from c92975c to 00e788b Compare September 29, 2017 18:08
@304NotModified 304NotModified modified the milestones: NLog.Web.AspNetCore 4.4.1 + NLog.Web 4.5.1, NLog.Web.AspNetCore 4.5 Sep 29, 2017
@304NotModified 304NotModified merged commit fc7c576 into master Sep 29, 2017
@304NotModified 304NotModified deleted the aspnetcore2 branch September 29, 2017 18:28
@snakefoot snakefoot added dependencies Pull requests that update a dependency file ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 2 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
NLog.Web.AspNetCore 4.5 + NLog.Web 4...
Development

Successfully merging this pull request may close these issues.

Asp.net core 2 support - remove Microsoft.Extensions.PlatformAbstractions package
2 participants
@304NotModified @snakefoot