Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseNLog for ASP.NET Core 2 #181

Merged
merged 2 commits into from
Sep 30, 2017
Merged

Add UseNLog for ASP.NET Core 2 #181

merged 2 commits into from
Sep 30, 2017

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Sep 29, 2017

Add UseNLog, Update dependency, Obsolete AddNLogWeb, Prepare for registering services

fixes #177 , fixes #181 , fixes #172

supersedes #173

@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #181 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #181   +/-   ##
=====================================
- Coverage      58%    58%   -1%     
=====================================
  Files          29     29           
  Lines         385    385           
  Branches       93     93           
=====================================
- Hits          224    222    -2     
  Misses        125    125           
- Partials       36     38    +2
Impacted Files Coverage Δ
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 81% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 95% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0216431...ed9de74. Read the comment docs.

@304NotModified 304NotModified merged commit 47f55e4 into master Sep 30, 2017
@304NotModified 304NotModified deleted the aspnetcore2-api branch September 30, 2017 00:19
This was referenced Sep 30, 2017
@snakefoot snakefoot added feature ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 2 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASP.NET Core 2 - simplify usage Move config from Startup to Config
2 participants