Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ServiceLocator public #231

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Made ServiceLocator public #231

merged 1 commit into from
Dec 5, 2017

Conversation

304NotModified
Copy link
Member

to support other DI systems

fixes #227

to support other DI systems
@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #231 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #231   +/-   ##
=====================================
- Coverage      59%    58%   -1%     
=====================================
  Files          29     29           
  Lines         395    395           
  Branches       92     92           
=====================================
- Hits          233    231    -2     
  Misses        126    126           
- Partials       36     38    +2
Impacted Files Coverage Δ
...etCore/LayoutRenderers/AspNetLayoutRendererBase.cs 88% <ø> (ø) ⬆️
...e/LayoutRenderers/IISInstanceNameLayoutRenderer.cs 0% <ø> (ø) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 80% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 96% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ddd31...98e1847. Read the comment docs.

@304NotModified 304NotModified merged commit 3ace8c5 into master Dec 5, 2017
@304NotModified 304NotModified deleted the public-ServiceLocator branch December 5, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using NLog with ASP.NET Core 2 and a Different DI Library
1 participant