Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogManager.LoadConfiguration + RC3 #245

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 23, 2018

Resolves #242 (Updates to latest NLog.Extensions.Logging ver. 1.0.0-rc07 and also resolves #239)

@304NotModified
Copy link
Member

thanks!

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #245   +/-   ##
=====================================
  Coverage      59%    59%           
=====================================
  Files          29     29           
  Lines         395    395           
  Branches       92     92           
=====================================
  Hits          233    233           
  Misses        126    126           
  Partials       36     36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b63748c...30b5d4e. Read the comment docs.

@snakefoot
Copy link
Contributor Author

@304NotModified Can this also be merged?

@304NotModified
Copy link
Member

yep, but have to check the version numbers here. It a bit out-dated

@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 21, 2018 via email

@304NotModified 304NotModified changed the title Use LogManager.LoadConfiguration Use LogManager.LoadConfiguration + RC3 Feb 21, 2018
@304NotModified
Copy link
Member

I see it should be RC3 and that already in this PR :)

@304NotModified 304NotModified merged commit 8e4072a into NLog:master Feb 21, 2018
@304NotModified
Copy link
Member

thanks!

@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 21, 2018

@304NotModified Found a bug, when doing AspNetCore1.1 Apps. Then it will fail to automatically register the NLog.Web.AspNetCore-assembly.

Looks like the AspNetCoreTests are not run for NetCoreApp1.1. Will try and fix that, so this bug would have been caught.

@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 21, 2018

@304NotModified After further investigation, then this was intended behavior (had to manual register assembly):

https://github.com/NLog/NLog.Web/wiki/Getting-started-with-ASP.NET-Core-(csproj---vs2017)

I have now created #249 to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use LogManager.LoadConfiguration Update to rc5
2 participants