-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LogManager.LoadConfiguration + RC3 #245
Conversation
thanks! |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=====================================
Coverage 59% 59%
=====================================
Files 29 29
Lines 395 395
Branches 92 92
=====================================
Hits 233 233
Misses 126 126
Partials 36 36 Continue to review full report at Codecov.
|
@304NotModified Can this also be merged? |
yep, but have to check the version numbers here. It a bit out-dated |
Nothing has happened in NLog.Web since the last dependency update.
|
I see it should be RC3 and that already in this PR :) |
thanks! |
@304NotModified Found a bug, when doing AspNetCore1.1 Apps. Then it will fail to automatically register the NLog.Web.AspNetCore-assembly. Looks like the AspNetCoreTests are not run for NetCoreApp1.1. Will try and fix that, so this bug would have been caught. |
@304NotModified After further investigation, then this was intended behavior (had to manual register assembly): I have now created #249 to improve this. |
Resolves #242 (Updates to latest NLog.Extensions.Logging ver. 1.0.0-rc07 and also resolves #239)