Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNX: Prevent stackoverflowException in ${aspnet-session} #41

Merged
merged 3 commits into from
Apr 15, 2016

Conversation

304NotModified
Copy link
Member

Prevent stackoverflowException in ${aspnet-session} by using HttpContext.Items.

In case of an session issue, ASP.NET session will log a warning. This could lead to a StackOverflowException.

We will prevent this by pushing and removing an item on context.Items

Details in #951

Fixes #951, fixes #43

needs confirmation.

@codecov-io
Copy link

Current coverage is 49.69%

Merging #41 into master will not affect coverage as of 8e89b05

@@            master     NLog/NLog.Extensions.Logging#41   diff @@
======================================
  Files           14      14       
  Stmts          163     163       
  Branches        28      28       
  Methods          0       0       
======================================
  Hit             81      81       
  Partial          8       8       
  Missed          74      74       

Review entire Coverage Diff as of 8e89b05


Uncovered Suggestions

  1. +3.68% via ...ringTargetWrapper.cs#195...200
  2. +3.68% via ...ringTargetWrapper.cs#167...172
  3. +3.07% via ...ringTargetWrapper.cs#89...93
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified changed the title Prevent stackoverflow in ${aspnet-request} by using context.Items DNX: Prevent stackoverflow in ${aspnet-request} by using context.Items Apr 2, 2016
@304NotModified 304NotModified modified the milestone: 4.2.2 Apr 2, 2016
@304NotModified 304NotModified force-pushed the fix-stackoverflow-session-renderer branch from 51f2a23 to f43eb18 Compare April 2, 2016 01:03
@304NotModified 304NotModified changed the title DNX: Prevent stackoverflow in ${aspnet-request} by using context.Items DNX: Prevent stackoverflowException in ${aspnet-request} Apr 4, 2016
@304NotModified 304NotModified changed the title DNX: Prevent stackoverflowException in ${aspnet-request} DNX: Prevent stackoverflowException in ${aspnet-session} Apr 4, 2016
@304NotModified 304NotModified force-pushed the fix-stackoverflow-session-renderer branch from 9f8a366 to 5eac777 Compare April 15, 2016 20:15
@304NotModified 304NotModified force-pushed the fix-stackoverflow-session-renderer branch from 5eac777 to 8e89b05 Compare April 15, 2016 20:20
@304NotModified 304NotModified merged commit e07ce41 into master Apr 15, 2016
@304NotModified 304NotModified deleted the fix-stackoverflow-session-renderer branch February 10, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of asp-session causing stack overflow DNX: Use of asp-session causing stack overflow
2 participants