Additional ASP.NET renderers (.NET Core compliant) & unit tests for .NET Core

[s-sreenath]

• aspnet-request-cookie - To Render cookie(s) from the request. Allows comma separated to get multiple cookie values. Can also allow json formatting.

• aspnet-request-querystring - querystring

• aspnet-request-method - the method (GET/POST etc)

• aspnet-request-referrer - To Render the Referrer URL.

• aspnet-request-url - To Render the Request URL.

• aspnet-useragent - To Capture the Useragent of the request.

• aspnet-host- The host of the request

• aspnet-mvc-action - action name

• aspnet-mvc-controller - controller name

Related #53

[304NotModified]

Looks good, maybe it's nice to create some helper methods to prevent code duplication

[s-sreenath]

What is the code duplication you are referring here?

[304NotModified]

I think it looks good, I added some notes but all of them are minor code style notes.

I prefer to keep the code between #if etc as small as possible, as this is better for maintainability.

[304NotModified]

OutPut => Output :)

[s-sreenath]

Done

[304NotModified]

Looks good!

We have to do three things:

1. 1. Update wiki
2. 2. Create new NLog release (using prerelease here)
3. 3. Enable unit tests for netcore on appveyor (appveyor.yml)

Correct?

[s-sreenath]

1 Update wiki

How do you think this needs to be done? Any pointers would be helpful.

2 Create new NLog release (using prerelease here)

Yes, we would need a release which has List Renderer support.

3 Enable unit tests for netcore on appveyor (appveyor.yml)

Yes.

We would also need to add examples on how to use it. May be pointers back to Tests Cases for starters.

[304NotModified]

I have merged it with the unit tests branch, so the unit tests should work now :)

1 Update wiki
How do you think this needs to be done? Any pointers would be helpful.

Add to https://github.com/NLog/NLog/wiki/Layout-Renderers and add the text "Introduced in NLog.Web 4.3". So new page for every layout renderer. Would be nice to add some docs to the "legacy" layout renderers.

2 Create new NLog release (using prerelease here)
Yes, we would need a release which has List Renderer support.

Can you check /review NLog/NLog#1439 for me? Im doubting especially with the current escape character: the backtick (`). To bad we cannot use backslash (because it's also an escape of the layout renderers already)

3 Enable unit tests for netcore on appveyor (appveyor.yml)
Yes.

This should be done now. Nice that this branch is in this repo :)

We would also need to add examples on how to use it. May be pointers back to Tests Cases for starters.

That would be nice indeed

[304NotModified]

oops broke the unit tests on net full. Worked on my machine...

[304NotModified]

don't get it. Works on my machine

[304NotModified]

sorry, broke it, working on fixing it. Merge was wrong

[304NotModified]

should be fixed

[304NotModified]

merged :)

[s-sreenath]

Documentation completed.