Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for name parameter on ${Assembly-version} #1578

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Aug 3, 2016

related #275

@304NotModified 304NotModified changed the title Add support for name parameter on ${assemby-veersion} Add support for name parameter on ${Assembly-version} Aug 3, 2016
@codecov-io
Copy link

Current coverage is 76% (diff: 100%)

Merging #1578 into master will decrease coverage by <1%

@@             master      #1578   diff @@
==========================================
  Files           270        270          
  Lines         16318      16327     +9   
  Methods        2611       2612     +1   
  Messages          0          0          
  Branches       1775       1777     +2   
==========================================
+ Hits          12432      12437     +5   
+ Misses         3483       3474     -9   
- Partials        403        416    +13   

Sunburst

Powered by Codecov. Last update 8ec0bf3...e1b2167

@304NotModified 304NotModified added this to the 4.3.7 milestone Aug 4, 2016
@304NotModified 304NotModified merged commit 9a26892 into master Aug 4, 2016
@304NotModified 304NotModified deleted the assembly-version-name branch August 4, 2016 22:43
304NotModified pushed a commit that referenced this pull request Aug 14, 2016
* Added option to not render empty literals on nested json objects (#1580)

* Added option to not render empty objects on nested json objects

* Add support for name parameter on (#1578)

* Bugfix: Use the culture when rendering the layout (#1556)

* Added unit tests

* Use the correct culture for rendering the string

* fix SL / fix tests

* fix culture

* split IFormatProvider and CultureInfo

* added related test

* update/expand tests

* fix xplat

* Allow overwriting possible nlog configuration file paths (#1469)

* Allow overwriting possible nlog configuration file paths

* Redesign after review

* Added tests

* Improvements after review

* move statics to XmlLoggingConfiguration

* FileTarget: Performance improvement for CleanupInvalidFileNameChars (#1582)

* FileTarget: Performance improvement for CleanupInvalidFileNameChars

* Added unit test

* Update for NLog 4.3.7

* Update README.md

[skip ci]

* fix unit test (#1589)

* Misc. fixes for .NET Core

* Remove wrap projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants