-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: <targets> after <rules> won't work #2113
Conversation
f67bfd1
to
bb93944
Compare
bb93944
to
ecc0eaf
Compare
supersedes #2096 |
ecc0eaf
to
e7d27ba
Compare
Maybe change the logic, so it always parses elements in this order (and not just targets first):
|
Indeed this was too Much quick fix |
Easy fix would be to always parse "RULES" last :) |
Have to look into this. The location of variables and includes, does matter. |
e7d27ba
to
7151953
Compare
That's indeed a much easier approach - keep it simple :) changed! |
Codecov Report
@@ Coverage Diff @@
## master #2113 +/- ##
=======================================
+ Coverage 81% 82% +<1%
=======================================
Files 291 291
Lines 20132 20375 +243
Branches 2390 2463 +73
=======================================
+ Hits 16378 16617 +239
- Misses 3143 3145 +2
- Partials 611 613 +2 |
Fixed in 4.4.10 and the release is queued. Will be online in a few hours! |
Fixes #2045