LoggingConfiguration - Modify and clone LoggingRules under lock #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2418 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 322 322
Lines 23046 23055 +9
Branches 2852 2858 +6
=======================================
Hits 18817 18817
- Misses 3494 3497 +3
- Partials 735 741 +6 |
snakefoot
force-pushed
the
LoggingConfigurationRulesSafe
branch
from
edac293 to
cac2366
Compare
|
will try to check this more in-depth this week |
snakefoot
force-pushed
the
LoggingConfigurationRulesSafe
branch
from
cac2366 to
e439536
Compare
|
I think this works, expect the ToList for the future. Added some small (rename) proposals |
snakefoot
force-pushed
the
LoggingConfigurationRulesSafe
branch
from
e439536 to
6acf558
Compare
304NotModified
approved these changes
Nov 27, 2017
snakefoot
force-pushed
the
LoggingConfigurationRulesSafe
branch
from
6acf558 to
0d3a7ee
Compare
snakefoot
force-pushed
the
LoggingConfigurationRulesSafe
branch
from
0d3a7ee to
c90a6fd
Compare
|
merged, thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #2393
An extended solution would be to implement a cache of the clone, and mark it dirty whenever LoggingRules are modified. But that is for another day.
The pretty solution would probably be to invent a special thread-safe IList-container, since LoggingRules is also a public property. But that is also for another day.