Database target entity framework connection string #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
DatabaseTargetEntityFramework
branch
from
bbf200e to
48a35a7
Compare
snakefoot
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2510 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 323 323
Lines 23352 23375 +23
Branches 2916 2920 +4
=======================================
+ Hits 19037 19051 +14
- Misses 3546 3554 +8
- Partials 769 770 +1 |
snakefoot
force-pushed
the
DatabaseTargetEntityFramework
branch
from
48a35a7 to
c129534
Compare
|
|
||
| databaseTarget.Initialize(null); | ||
| Assert.NotNull(databaseTarget.ProviderFactory); | ||
| Assert.Equal(typeof(SqlClientFactory), databaseTarget.ProviderFactory.GetType()); |
There was a problem hiding this comment.
Could you please add an assert here for the connectionstring?
snakefoot
force-pushed
the
DatabaseTargetEntityFramework
branch
from
c129534 to
b8e8a5f
Compare
|
thx! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded the code from #2308 directly into DatabaseTarget. Resolves #98
Since "provider" is a common keyword in the connectionstring, and no one have requested NLog to parse it, then I have decided to only parse it when the connectionstring seems to come from entity framework.