Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogManager class refactored #479

Merged
1 commit merged into from
Dec 29, 2014
Merged

LogManager class refactored #479

1 commit merged into from
Dec 29, 2014

Conversation

ie-zero
Copy link
Contributor

@ie-zero ie-zero commented Dec 27, 2014

In LogManager class

  • New method GetClassFullName() created from the common code extracted from GetCurrentClassLogger() and GetCurrentClassLogger(Type) methods.
  • Try Catch block moved from LogManager static constructor into SetupTerminationEvents() method.
  • Comments and code reformatted.

Note: The string GetClassFullName() method in LogManager class should be tested in SilverLight.

In LogManager class
* New method GetClassFullName() created from the common code extracted
from GetCurrentClassLogger() and GetCurrentClassLogger(Type) methods.
* Try Catch block moved from LogManager static constructor into
SetupTerminationEvents() method.
* Comments and code reformatted.
ghost pushed a commit that referenced this pull request Dec 29, 2014
@ghost ghost merged commit 73f3291 into NLog:v4.0 Dec 29, 2014
@ghost ghost added the enhancement Improvement on existing feature label Dec 29, 2014
@ghost ghost added this to the 4.0 milestone Dec 29, 2014
@ghost
Copy link

ghost commented Dec 29, 2014

Thanks for the pull requets, looks good as always. It have been merged

@ie-zero ie-zero deleted the Refactor_LogManager branch December 30, 2014 11:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant