Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests to a separate repo #1235

Closed
qwertymodo opened this issue Sep 10, 2018 · 1 comment · Fixed by #2081
Closed

Move tests to a separate repo #1235

qwertymodo opened this issue Sep 10, 2018 · 1 comment · Fixed by #2081
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@qwertymodo
Copy link

The test directory is very large (currently >150MB), and checking out the repo requires checking out that entire test directory as well, even if you just want to build the code without running the tests. Splitting the test directory into a separate repo and including it as a submodule or subtree would eliminate this issue and make it a lot more friendly for people to use this library from the git repo.
@nlohmann
Copy link
Owner

Duplicate of #96

Discussion on a solution: #1184

@nlohmann nlohmann added the solution: duplicate the issue is a duplicate; refer to the linked issue instead label Sep 10, 2018
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann linked a pull request May 4, 2020 that will close this issue
Use external test data #2081
Merged
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging a pull request may close this issue.

Use external test data nlohmann/json
2 participants
@nlohmann @qwertymodo