Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not linking properly with cmake #1709

Closed
anastasia-v-r opened this issue Aug 16, 2019 · 5 comments
Closed

not linking properly with cmake #1709

anastasia-v-r opened this issue Aug 16, 2019 · 5 comments
Labels
kind: bug solution: invalid the issue is not related to the library

Comments

@anastasia-v-r
Copy link

Using conan and cmake with the provided conan link inside my conanfile.txt, this library does not work at all. i can't access any of the code or files.
I link sfml the exact same way yet sfml works like any other conan integrated library while this library does not.

@nlohmann
Copy link
Owner

In order to asses your issue, we need the following information:

  • What is the issue you have?

  • Please describe the steps to reproduce the issue. Can you provide a small but working code example?

  • What is the expected behavior?

  • And what is the actual behavior instead?

  • Which compiler and operating system are you using? Is it a supported compiler?

  • Did you use a released version of the library or the version from the develop branch?

  • If you experience a compilation error: can you compile and run the unit tests?

@nlohmann nlohmann added the state: needs more info the author of the issue needs to provide more details label Aug 16, 2019
@anastasia-v-r
Copy link
Author

anastasia-v-r commented Aug 27, 2019

Issue:
When using Conan and Cmake, this libraries code is inaccessible

Example:
#include <nlohmann/json>
Is considered to be invalid and the library does not at all exist for usage. This is easily testable by right clicking any includes in VS19 and clicking Go to document to read the header file

Expected Behaviour:
#include <nlohmann/json> does not error and using Go to document test works

Compiler and OS:
Ninja? MSVCv14.21.27702 and Windows 10 v 17134.950

IDE:
VisualStudio19

Which branch:
The stable release conan branch

Tests:
I have no idea how to run unit tests and cant seem to figure that one out

@nlohmann
Copy link
Owner

As the README states: Please file issues on Conan here: https://github.com/vthiery/conan-jsonformoderncpp/issues

If you are using Conan to manage your dependencies, merely add jsonformoderncpp/x.y.z@vthiery/stable to your conanfile.py's requires, where x.y.z is the release version you want to use. Please file issues here if you experience problems with the packages.

(from https://github.com/nlohmann/json#package-managers).

@nlohmann nlohmann added solution: invalid the issue is not related to the library and removed state: needs more info the author of the issue needs to provide more details labels Aug 27, 2019
@anastasia-v-r
Copy link
Author

Ok. I've opened an issue there. to be more clear, im forced to use the cmake method, find_package which isnt necesarry for the other 4 packages my program uses which increases the complexity of the cmake file due to subsequent necesarry cmake commands far more than i like by inhibiting my ability to use just 1 foreach loop per build target (release, debug, etc). If this still sounds like a maintainer problem and not a package creator problem then you are welcome to close this issue.

@nlohmann
Copy link
Owner

Thanks for checking back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug solution: invalid the issue is not related to the library
Projects
None yet
Development

No branches or pull requests

2 participants