Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove/replace assert with exceptions #1752

Closed
Tibbel opened this issue Sep 16, 2019 · 2 comments
Closed

remove/replace assert with exceptions #1752

Tibbel opened this issue Sep 16, 2019 · 2 comments
Labels
kind: enhancement/improvement solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated

Comments

@Tibbel
Copy link

Tibbel commented Sep 16, 2019

Hello,

is it possible to remove the assert's-statements in the library or
add a compiler directive to replace it with exceptions.

kind regards
@nlohmann
Copy link
Owner

This is currently not planned. Each assertion is a guard for undefined behavior. The only option you have is to switch off assertions by defining NDEBUG.

@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Oct 16, 2019
@stale stale bot closed this as completed Oct 23, 2019
@nlohmann nlohmann added the solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) label Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement/improvement solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlohmann @Tibbel