Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ciso646 header become obsolete #1782

Closed
svak opened this issue Oct 8, 2019 · 2 comments
Closed

ciso646 header become obsolete #1782

svak opened this issue Oct 8, 2019 · 2 comments
Labels
kind: enhancement/improvement

Comments

@svak
Copy link

svak commented Oct 8, 2019

header will be removed in C++20. I think it should not be used.
@tete17 tete17 mentioned this issue Oct 8, 2019
Closed
4 tasks
@nlohmann
Copy link
Owner

nlohmann commented Oct 9, 2019

We should use a Hedley macro to detect C++20 compilers and remove the include only there. For C++11, the header is still needed, in particular for MSVC (see https://ci.appveyor.com/project/nlohmann/json/builds/27972282).

@svak
Copy link
Author

svak commented Oct 9, 2019

Understood

@svak svak closed this as completed Oct 9, 2019
@nlohmann nlohmann mentioned this issue May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlohmann @svak