Can't compile from_json(std::valarray<T>).

[ghost]

Following code couldn't be compiled because the from_json implementation uses the private member 'm_value'.

json Version: v3.7.0

#include <nlohmann/json.hpp>

using json = nlohmann::json;

int main()
{
   json j = json::array({1, 0, 2});
   j.get<std::valarray<int>>();
}

https://wandbox.org/permlink/ifYduziYXUtfgP4n

[nlohmann]

Indeed. Changing

std::copy(j.m_value.array->begin(), j.m_value.array->end(), std::begin(l));

to

std::copy(j.begin(), j.end(), std::begin(l));

fixes the issue.

[nlohmann]

---

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

• ✨ New Feature
• 🐛 Bug Fix
• ⚡️ Improvement
• 🔨 Further Change
• 🔥 Deprecated function

Description

• fix conversion to std::valarray

---