Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect CMake FetchContent example #2142

Closed
quentin-dev opened this issue May 27, 2020 · 1 comment · Fixed by #2143
Closed

Incorrect CMake FetchContent example #2142

quentin-dev opened this issue May 27, 2020 · 1 comment · Fixed by #2143
Labels
documentation kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@quentin-dev
Copy link
Contributor

What is the issue you have?

The README section about CMake FetchContent integration seems to have a typo

FetchContent_Declare(json
  GIT_REPOSITORY https://github.com/nlohmann/json
  GIT_TAG v3.7.3)

Should be

FetchContent_Declare(json
  GIT_REPOSITORY https://github.com/nlohmann/json.git
  GIT_TAG v3.7.3)

as is shown in the examples given by CMake
@quentin-dev quentin-dev mentioned this issue May 27, 2020
Merged
4 tasks
@nlohmann nlohmann added documentation release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 28, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 28, 2020
@nlohmann
Copy link
Owner

Closed with #2143

@nlohmann nlohmann linked a pull request May 28, 2020 that will close this issue
Fix issue#2142: readme: fix typo in CMake FetchContent example #2143
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging a pull request may close this issue.

Fix issue#2142: readme: fix typo in CMake FetchContent example
2 participants
@nlohmann @quentin-dev