Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md overuses template keyword before get function #4205

Closed
1 of 2 tasks
davidstone opened this issue Nov 14, 2023 · 2 comments
Closed
1 of 2 tasks

README.md overuses template keyword before get function #4205

davidstone opened this issue Nov 14, 2023 · 2 comments

Comments

@davidstone
Copy link

Description

The documentation contains 18 matches for template get. All of them should just be get except for the line value = j.template get<T>(); // oops! which is correct as in.

Reproduction steps

Read the readme

Expected vs. actual results

Should not have template keyword

Minimal code example

No response

Error messages

No response

Compiler and operating system

N/A

Library version

develop current

Validation

@nlohmann
Copy link
Owner

IIRC there were compilers with issues without the template keyword, so we decided to add it just in case. If you have a concrete example, feel free to open a PR.

@nlohmann
Copy link
Owner

See #4038 and #4039.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants