Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to improve ignores.. #567

Closed
KennethThompson opened this issue Apr 21, 2017 · 1 comment
Closed

Need to improve ignores.. #567

KennethThompson opened this issue Apr 21, 2017 · 1 comment
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@KennethThompson
Copy link

KennethThompson commented Apr 21, 2017 •
edited
Loading

I love this project.. but why does it take 133.06 MiB? Appears to be a short coming of your github ignore file.

ken@ken-VirtualBox:~/git-repos/septemmud$ git submodule add https://github.com/nlohmann/json.git
Cloning into 'json'...
remote: Counting objects: 31983, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 31983 (delta 21), reused 0 (delta 0), pack-reused 31929
Receiving objects: 100% (31983/31983), 133.06 MiB | 533.00 KiB/s, done.
Resolving deltas: 100% (26702/26702), done.
Checking connectivity... done.
ken@ken-VirtualBox:~/git-repos/septemmud$
@nlohmann
Copy link
Owner

Duplicates #96.

@nlohmann nlohmann added the solution: duplicate the issue is a duplicate; refer to the linked issue instead label Apr 21, 2017
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

No branches or pull requests
2 participants
@nlohmann @KennethThompson