Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] When using this as git submodule, will it clone the whole thing include test data and benchmark? #620

Closed
tuananh opened this issue Jun 15, 2017 · 1 comment · Fixed by #2081
Closed

[Question] When using this as git submodule, will it clone the whole thing include test data and benchmark? #620

tuananh opened this issue Jun 15, 2017 · 1 comment · Fixed by #2081
Assignees
@nlohmann
Labels
kind: question release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@tuananh
Copy link

tuananh commented Jun 15, 2017

it seems the actual source is small but test and benchmark folder is huge (200MB ++).

Should I just copy the code from json.hpp or is there anyway to use this as submodule without cloning test folder and benchmark folder?

Thank you.
@tuananh
Copy link
Author

tuananh commented Jun 15, 2017 •
edited
Loading

Duplicate of #556 #482 #96

@nlohmann nlohmann added kind: question solution: duplicate the issue is a duplicate; refer to the linked issue instead labels Jun 15, 2017
@nlohmann nlohmann mentioned this issue Sep 8, 2017
Closed
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann linked a pull request May 4, 2020 that will close this issue
Use external test data #2081
Merged
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: question release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging a pull request may close this issue.

Use external test data nlohmann/json
2 participants
@nlohmann @tuananh