Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using your library (without modification) in another library #796

Closed
chetmurthy opened this issue Oct 22, 2017 · 3 comments
Closed

Using your library (without modification) in another library #796

chetmurthy opened this issue Oct 22, 2017 · 3 comments

Comments

@chetmurthy
Copy link

Hi,

First, this is wonderful. Thank you so much!

Second, I'd like to use your library in some code I'm writing to provide a JSON wire-format for Apache Thrift. I'll be distributing this code on github in source, under the Apache license, and would -like- to be able to include a copy of your json.hpp (with your license) in my source-tree. Only b/c it'll be convenient that people who clone this repo won't have to go clone other repos also. Of course, I'd make sure to credit you and point at your git repo.

Is this something you'd find agreeable?

@nlohmann
Copy link
Owner

I am not a license expert, but I think it is no problem to include my library as long as you also redistribute the MIT license text.

And of course I would be happy if the library is useful to you, so please go ahead and add it to Apache Thrift. Please let me know once it is in so I can mention in in my README file.

@chetmurthy
Copy link
Author

Hello, everything just as you say, with one correction: this probably won't be a -part- of Thrift. Rather, this library is an addon to Thrift.

@nlohmann
Copy link
Owner

Alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants