Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation path is incorrect #910

Closed
mprync opened this issue Jan 11, 2018 · 6 comments
Closed

Installation path is incorrect #910

mprync opened this issue Jan 11, 2018 · 6 comments
Assignees
@nlohmann
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.1.0

Comments

@mprync
Copy link

mprync commented Jan 11, 2018 •
edited
Loading

Calling "make install" now installs json.hpp to "nlohmann/src/json.hpp".

No sure if this was intentional.

The issue is from the latest PR change here.
@mprync mprync changed the title Installation path incorrect Installation path is incorrect Jan 11, 2018
@nlohmann
Copy link
Owner

I am not CMake expert - what should be the value in your opinion?

@nlohmann nlohmann added the state: help needed the issue needs help to proceed label Jan 13, 2018
@theodelrieu
Copy link
Contributor

Oops I haven't tried that, I'll take a look this afternoon

@theodelrieu theodelrieu mentioned this issue Jan 13, 2018
Merged
3 tasks
@nlohmann
Copy link
Owner

Fixed with merging #911.

@InFaMoUsZero Could you please check if this fixes the issue for you?

@nlohmann nlohmann added solution: proposed fix a fix for the issue has been proposed and waits for confirmation and removed state: help needed the issue needs help to proceed labels Jan 14, 2018
@nlohmann nlohmann added this to the Release 3.1.0 milestone Jan 14, 2018
@nlohmann nlohmann self-assigned this Jan 14, 2018
@mprync
Copy link
Author

mprync commented Jan 14, 2018

@nlohmann Sure, I can test this on Tuesday and hopefully get this closed off.

@mprync
Copy link
Author

mprync commented Jan 16, 2018

@nlohmann I can confirm this has now fixed the issue.

@mprync mprync closed this as completed Jan 16, 2018
@nlohmann
Copy link
Owner

Thanks for checking back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.1.0
Development

No branches or pull requests
3 participants
@nlohmann @mprync @theodelrieu