Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirNow UTC offset test cases - recent data no longer has bad UTC offsets? #160

Closed
zmoon opened this issue Feb 19, 2024 · 2 comments
Closed
Assignees
Labels
in-develop Addressed/fixed/resolved in `develop` branch maintenance

Comments

@zmoon
Copy link
Member

zmoon commented Feb 19, 2024

Noticed in today's scheduled CI run.

FAILED tests/test_airnow.py::test_check_zero_utc_offsets[yesterday-null] - assert 0 > 0
 +  where 0 = <bound method NDFrame._add_numeric_operations.<locals>.sum of 0       False\n1       False\n2       False\n3       False\n4       False\n        ...  \n2022    False\n2023    False\n2024    False\n2025    False\n2026    False\nName: utcoffset, Length: 2027, dtype: bool>()
 +    where <bound method NDFrame._add_numeric_operations.<locals>.sum of 0       False\n1       False\n2       False\n3       False\n4       False\n        ...  \n2022    False\n2023    False\n2024    False\n2025    False\n2026    False\nName: utcoffset, Length: 2027, dtype: bool> = 0       False\n1       False\n2       False\n3       False\n4       False\n        ...  \n2022    False\n2023    False\n2024    False\n2025    False\n2026    False\nName: utcoffset, Length: 2027, dtype: bool.sum
 +      where 0       False\n1       False\n2       False\n3       False\n4       False\n        ...  \n2022    False\n2023    False\n2024    False\n2025    False\n2026    False\nName: utcoffset, Length: 2027, dtype: bool = <bound method Series.isnull of 0      -4.0\n1      -4.0\n2      -4.0\n3      -4.0\n4      -4.0\n       ... \n2022    5.0\n2023    5.0\n2024    5.0\n2025    5.0\n2026    5.0\nName: utcoffset, Length: 2027, dtype: float64>()
 +        where <bound method Series.isnull of 0      -4.0\n1      -4.0\n2      -4.0\n3      -4.0\n4      -4.0\n       ... \n2022    5.0\n2023    5.0\n2024    5.0\n2025    5.0\n2026    5.0\nName: utcoffset, Length: 2027, dtype: float64> = 0      -4.0\n1      -4.0\n2      -4.0\n3      -4.0\n4      -4.0\n       ... \n2022    5.0\n2023    5.0\n2024    5.0\n2025    5.0\n2026    5.0\nName: utcoffset, Length: 2027, dtype: float64.isnull
 +          where 0      -4.0\n1      -4.0\n2      -4.0\n3      -4.0\n4      -4.0\n       ... \n2022    5.0\n2023    5.0\n2024    5.0\n2025    5.0\n2026    5.0\nName: utcoffset, Length: 2027, dtype: float64 =                     time     siteid  BARPR  ...  msa_name  state_name  epa_region\n0    2024-02-18 00:00:00  000010601    NaN  ...       NaN          CC          CA\n1    2024-02-18 00:00:00  000020104    NaN  ...       NaN          CC          CA\n2    2024-02-18 00:00:00  000020301    NaN  ...       NaN          CC          CA\n3    2024-02-18 00:00:00  000020401    NaN  ...       NaN          CC          CA\n4    2024-02-18 00:00:00  000030502    NaN  ...       NaN          CC          CA\n...                  ...        ...    ...  ...       ...         ...         ...\n2022 2024-02-18 00:30:00  DS1010001    NaN  ...       NaN          DS        DSIN\n2023 2024-02-18 00:30:00  DS1010002    NaN  ...       NaN          DS        DSIN\n2024 2024-02-18 00:30:00  DS1010003    NaN  ...       NaN          DS        DSIN\n2025 2024-02-18 00:30:00  DS1010004    NaN  ...       NaN          DS        DSIN\n2026 2024-02-18 00:30:00  DS1010005    NaN  ...       NaN          DS        DSIN\n\n[2027 rows x 58 columns].utcoffset
FAILED tests/test_airnow.py::test_check_zero_utc_offsets[yesterday-leave] - assert not True
 +  where True = Empty DataFrame\nColumns: [siteid, site, longitude]\nIndex: [].empty
@zmoon zmoon self-assigned this Feb 21, 2024
@zmoon
Copy link
Member Author

zmoon commented Feb 26, 2024

Today though, it didn't fail... so seems to depend on the day. For example, got another failure today in #164 .

@zmoon
Copy link
Member Author

zmoon commented Jul 18, 2024

#174 should have addressed this.

@zmoon zmoon added the in-develop Addressed/fixed/resolved in `develop` branch label Jul 18, 2024
@zmoon zmoon closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-develop Addressed/fixed/resolved in `develop` branch maintenance
Projects
None yet
Development

No branches or pull requests

1 participant