-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scipy>1.12
on macos
#153
Comments
I don't have any issues pinning |
OK thanks, can you point out where in the perturbation we use interpolation? Just for the sake of documenting the issue. Hopefully |
Not sure, in this code it just uses the interp function in pandas.. https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/71804ad4488492471da9971d564aee76e648c94f/ensembleperturbation/perturbation/atcf.py#L1562C3-L1575C22
|
OK thanks, I guess that's it, I'll double check when we want to look into this issue. |
scipy>0.12
on macosscipy>1.13
on macos
scipy>1.13
on macosscipy>1.12
on macos
Note to self, |
As also noted in oceanmodeling/adcircpy#190, the latest
scipy
seems to have some issues on macos. It results in different values. When calculating the perturbation I think we're doing some type of interpolation again, which can be causing the issue I see in the failed testPinning the version seems to resolve the issue see 27f63da in PR #149
@WPringle what do you think? I'll need to confirm by making sure all tests go through, but for now I don't get the difference in perturbed json file at least (there are other problems I have to solve though!)
The text was updated successfully, but these errors were encountered: