Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename node-pre-gyp module_name #58

Open
farfromrefug opened this issue Mar 7, 2017 · 6 comments
Open

rename node-pre-gyp module_name #58

farfromrefug opened this issue Mar 7, 2017 · 6 comments

Comments

@farfromrefug
Copy link

Right now the module_name for node-pre-gyp is "binding"
However if you want to provide your own custom hosted binaries, it depends on "module_name". Thus "module_name" should be something like "bluetooth-hci-socket"

That would be awesome!

@sandeepmistry
Copy link
Collaborator

@farfromrefug please submit a pull request for this.

@ghost
Copy link

ghost commented Jun 18, 2018

a PR that includes that change is here #87

@ghost
Copy link

ghost commented Jun 18, 2018

Oh sorry, I totally missed the PR already submitted by you!

@rzr
Copy link

rzr commented Oct 16, 2020

Is this issue relevant in this release:

https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-6

@rzr
Copy link

rzr commented Jan 6, 2021

Feel free to comment this related ticket:

abandonware#9

@rzr
Copy link

rzr commented Oct 1, 2021

May you forward your ticket to downstream version:

#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants